Revert "cnetlink: sync route cache on linkdown events" #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncing routes on link down may trigger updates on link local routes due to route flag changes, but baseboxd is not prepared to handle this, and causes all l3 neighbors on that link to be treated as unroutable. IPv6 routes with nexthops seem to behave differently than IPv4 routes, and seem to reappear silently on link up again. Since there is no notification (again) from the kernel, we miss the reappearance of the route. Due to the amount of breakage, lets's revert this for now until we have addresses these two issues. This reverts commit 9a58b5d. Signed-off-by: Jonas Gorski <[email protected]>
jklare
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing routes on link down may trigger updates on link local routes due to route flag changes, but baseboxd is not prepared to handle this, and causes all l3 neighbors on that link to be treated as unroutable.
IPv6 routes with nexthops seem to behave differently than IPv4 routes, and seem to reappear silently on link up again. Since there is no notification (again) from the kernel, we miss the reappearance of the route.
Due to the amount of breakage, lets's revert this for now until we have addresses these two issues.
This reverts commit 9a58b5d.
Description
Motivation and Context
How Has This Been Tested?