[bitnami/argo-cd] Fix check for ArgoCD controller replica count #36347
Conversation
|
Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines. Feel free to reach out if you have any questions or need assistance with the signing process. |
|
My commits seem to be already signed. Is it ok for you? |
|
It seems the branch is not updated with the signed commits, according to https://github.com/bitnami/charts/pull/36347/checks?check_run_id=52681859865, what's needed to do is
|
Signed-off-by: Luca Bertelli <[email protected]>
Signed-off-by: Luca Bertelli <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]> Signed-off-by: Luca Bertelli <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
juan131
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix
Description of the change
This PR fixes the ArgoCD application controller sharding configuration by using the Kubernetes Downward API to inject the pod name into the
ARGOCD_APPLICATION_CONTROLLER_NAMEenvironment variable.Benefits
Enables proper application controller sharding: Each controller replica can correctly determine its shard assignment starting from its unique pod name
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm