WalletApplication: Don't set Threading.USER_THREAD#4042
Open
msgilligan wants to merge 1 commit intobitcoinj:masterfrom
Open
WalletApplication: Don't set Threading.USER_THREAD#4042msgilligan wants to merge 1 commit intobitcoinj:masterfrom
msgilligan wants to merge 1 commit intobitcoinj:masterfrom
Conversation
664870a to
ea38984
Compare
I checked all listeners in the application and they were already being set to use the JavaFX thread where necessary, except one instance in `SendMoneyController`, which is fixed in this commit. The application should be in control of when to use the JavaFX thread and when not to use it. The JavaFX thread should only be used when we are actually updating the UI. This change also reduces our usage of mutable global state and allows us to make USER_THREAD final if we so choose.
ea38984 to
7c642fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I checked all listeners in the application and they were already being set to use the JavaFX thread where necessary, except one instance in
SendMoneyController.The application should be in control of when to use the JavaFX thread and when not to use it. The JavaFX thread should only be used when we are actually updating the UI.