Improve platform website's create new page (#11260) #11261
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the platform website's create new page by updating default values for project creation parameters. The changes make the notification and aspire features enabled by default instead of disabled.
- Updates notification parameter default from false to true
- Updates aspire parameter default from false to true
WalkthroughUpdated default values for two boolean parameters (notification, aspire) to true in Templates05CreateProjectPage.razor.cs. No public APIs altered. Control flow remains the same; flags are emitted only when current values differ from their defaults. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates05CreateProjectPage.razor.cs (1)
174-177: Quote the project name to support spaces/special charactersSafer for copy/paste usage across shells:
- return $"--name {name} "; + return $"--name \"{name}\" ";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (1)
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates05CreateProjectPage.razor.cs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build and test
🔇 Additional comments (2)
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates05CreateProjectPage.razor.cs (2)
13-13: Verify Template Defaults for CLI FlagsWe couldn’t locate any
.template.config/template.jsonortemplate.jsonin this repo defining defaults fornotificationoraspire. Please confirm the bit-bp dotnet template’s actual defaults for these flags:
- If the CLI template defaults for
--notificationand--aspireremain false, update your code soIsModifiedbecomestruewhen the UI shows “enabled”:- private Parameter<bool> notification = new() { Value = true, Default = true }; + private Parameter<bool> notification = new() { Value = true, Default = false }; - private Parameter<bool> aspire = new() { Value = true, Default = true }; + private Parameter<bool> aspire = new() { Value = true, Default = false };- If the template defaults have been flipped to true, you can leave the current assignments as-is.
Locations to check:
- src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates05CreateProjectPage.razor.cs
• Line 13 –notification
• Line 17 –aspireThis ensures that when the UI shows a feature as “on,” the corresponding
--notification/--aspireflags are actually emitted.
214-217: Verify CLI switch name consistencyI wasn’t able to find any occurrences of
fileStorageorfilesStoragein the project’s template definitions. Please confirm that the switch emitted by this code matches the expected parameter name in your CLI templates. If the template expects--fileStorage(singular), update the code accordingly.• File:
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates05CreateProjectPage.razor.cs (lines 214–217)Suggested change if needed:
- private string GetFileStorageCommand() - { - return $"--filesStorage {fileStorage.Value} "; - } + private string GetFileStorageCommand() + { + return $"--fileStorage {fileStorage.Value} "; + }
closes #11260
Summary by CodeRabbit