PM-10051: Add the intro carousel with the first content page #780
Conversation
|
No New Or Fixed Issues Found |
There was a problem hiding this comment.
🤔 Has product/design seen and approved the landscape view? Should it have a landscape view or should we just force it to portrait? IMO it feels a bit weird the title not being centered.
⛏️ Additionally, the image is being cut at the bottom, some fingers cannot be seen hehe.
There was a problem hiding this comment.
The Authenticator app has a similar carousel for first-time users, and it handles landscape in a similar manner.
There was a problem hiding this comment.
🤔 Has product/design seen and approved the landscape view? Should it have a landscape view or should we just force it to portrait? IMO it feels a bit weird the title not being centered.
The landscape design exists in the Figma file, which I think has been reviewed/approved by product and design.
⛏️ Additionally, the image is being cut at the bottom, some fingers cannot be seen hehe.
The view does scroll, so you can scroll down to see the image or any overflowing text. But I think the image should be slightly smaller in landscape, so I can update that.
There was a problem hiding this comment.
Oh missed the landscape design in Figma, sorry.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #780 +/- ##
==========================================
+ Coverage 88.19% 88.22% +0.03%
==========================================
Files 577 581 +4
Lines 29213 29325 +112
==========================================
+ Hits 25763 25873 +110
- Misses 3450 3452 +2 ☔ View full report in Codecov by Sentry. |
|
|
||
| /// A model representing the data to display on a single page in the carousel. | ||
| /// | ||
| struct CarouselPage: Equatable, Identifiable { |
There was a problem hiding this comment.
🤔 Is there a reason the CarouselPage needs to be Identifiable? I was able to achieve the same effect with just an Equatable enum in the Authenticator app.
There was a problem hiding this comment.
It needed to be Identifiable to iterate over the array with ForEach. An enum could work too, I just liked the ability to define the list of pages as a list within the state.
| } | ||
| .padding(.vertical, 16) | ||
| .frame(maxWidth: .infinity, minHeight: reader.size.height) | ||
| .scrollView(addVerticalPadding: false) |
There was a problem hiding this comment.
🤔 By putting the scroll view here, on landscape modes with long text or big text (due to font size), it means that the image scrolls alongside the text, rather than being separate from the text-as-scrollview. Is this what we want? (On the Authenticator, I split the image out in landscape so only the text scrolled; not sure what the proper choice actually is, though, but both apps should eventually match in that regard)
There was a problem hiding this comment.
Good callout! I will update this to just scroll the text.
🎟️ Tracking
PM-10051
📔 Objective
Adds the setup for the carousel along with the first carousel page. The remaining pages will be coming in a future PR.
Since we don't yet have a feature flag for this, there isn't a way to get to this in the app. For testing, setting the initial route on the app processor to
.auth(.introCarousel)will take you to the carousel.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes