[PM-9705] Added device and CI build info to version copy #782
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
==========================================
- Coverage 88.42% 88.42% -0.01%
==========================================
Files 596 596
Lines 30069 30086 +17
==========================================
+ Hits 26590 26605 +15
- Misses 3479 3481 +2 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
KatherineInCode
left a comment
There was a problem hiding this comment.
I know this is a draft, and it's looking good so far! Just noticed a few things.
BitwardenShared/UI/Platform/Settings/Settings/About/AboutProcessorTests.swift
Outdated
Show resolved
Hide resolved
| let text = state.copyrightText + "\n\n" + state.version | ||
| services.pasteboardService.copy(text) | ||
| var infoParts = [ | ||
| state.copyrightText + "\n", |
There was a problem hiding this comment.
🤔 Would it be better instead of doing string concatenation here, to just list the "\n" as another element in the array, since we're doing a bunch of concatenation later with the .joined? That would help make it more clear when reading what the expected output is vis-à-vis blank lines. Same would apply to all the newlines embedded in strings here.
There was a problem hiding this comment.
Tried it but the problem is that it adds an additional new line:
copyright\n\n\n instead of copyright\n\n
Because it'd be the \n between copyright and the \n element and then another \n between the \n element and version.
There was a problem hiding this comment.
🤦🏼♀️ Right, that makes sense. Could just do a "" on a separate line, instead? But yeah, that's reasonable either way.
| services: services, | ||
| state: AboutState() | ||
| state: AboutState(), | ||
| systemDevice: UIDevice.current |
There was a problem hiding this comment.
🤔 There is a HasSystemDevice already on the Services; would it be possible to pass that in here?
There was a problem hiding this comment.
oh missed that, it's a really good idea thanks!
…ssorTests.swift Co-authored-by: Katherine Bertelsen <[email protected]>
…added its step into the build workflow. Also addressed PR feedback.
| "Commit hash": "${commit_hash}", | ||
| "CI Run ID": "${ci_run_id}", | ||
| "CI Run Number": "${ci_run_number}", | ||
| "CI Run Attempt": "${ci_run_attempt}", |
There was a problem hiding this comment.
🎨 We should probably be consistent with casing. I think our standard is just uppercasing the first word, so "CI run ID", "CI run number", and "CI run attempt"?
🎟️ Tracking
PM-9705
📔 Objective
Add device and CI Build info to what is copied in the about version copy action.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes