[PM-11133] Update Networking module for strict concurrency#851
Merged
KatherineInCode merged 1 commit intomainfrom Aug 21, 2024
Merged
[PM-11133] Update Networking module for strict concurrency#851KatherineInCode merged 1 commit intomainfrom
KatherineInCode merged 1 commit intomainfrom
Conversation
Contributor
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 609 609
Lines 30303 30303
=======================================
Hits 26820 26820
Misses 3483 3483 ☔ View full report in Codecov by Sentry. |
fedemkr
approved these changes
Aug 20, 2024
phil-livefront
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11133
📔 Objective
This is part of the iOS 18 / Xcode 16 / Swift 6 effort
This updates our Networking module to have no warnings with strict concurrency checking turned on, and also annotates
Sendableto eliminate warnings in the main project.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes