Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Oct 4, 2024

🎟️ Tracking

PM-12580

📔 Objective

Fixes the internal beta app CI by moving the patch patching out of the job.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner October 4, 2024 09:23
@vvolkgang vvolkgang enabled auto-merge (squash) October 4, 2024 09:26
@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (5e5208c) to head (9504822).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
- Coverage   89.10%   89.09%   -0.01%     
==========================================
  Files         657      657              
  Lines       41317    41317              
==========================================
- Hits        36814    36812       -2     
- Misses       4503     4505       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vvolkgang vvolkgang merged commit cc8039a into main Oct 4, 2024
@vvolkgang vvolkgang deleted the fix-internal-beta branch October 4, 2024 09:35
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Logo
Checkmarx One – Scan Summary & Detailsd6e48096-3403-40fb-bc94-61f59122fdcf

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /CI-main.yml: 86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants