Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PM-12269] Clean up references to the beta#1073

Merged
KatherineInCode merged 2 commits intomainfrom
katherine/clean-up
Oct 23, 2024
Merged

[PM-12269] Clean up references to the beta#1073
KatherineInCode merged 2 commits intomainfrom
katherine/clean-up

Conversation

@KatherineInCode
Copy link
Contributor

📔 Objective

Now that the app is released on the app store, and not in beta, we should remove references to it being in beta.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes


> [!WARNING]
> This is the new native Bitwarden Beta app repository. For the pubicly available apps in App Store / Play Store, submit your report in [bitwarden/mobile](https://github.com/bitwarden/mobile)
> This is the new native Bitwarden app repository. For the pubicly available apps in App Store / Play Store, submit your report in [bitwarden/mobile](https://github.com/bitwarden/mobile)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I think we should also remove the report submission, given that the publicly available apps on iOS is this one, the native app.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good call! I didn't read it as closely as I should have!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

Logo
Checkmarx One – Scan Summary & Details9bae0f2e-63ba-401f-828a-f4bab0b38d15

No New Or Fixed Issues Found

@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (fe3f6bd) to head (504311e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1073   +/-   ##
=======================================
  Coverage   89.37%   89.38%           
=======================================
  Files         672      672           
  Lines       42371    42371           
=======================================
+ Hits        37870    37872    +2     
+ Misses       4501     4499    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KatherineInCode KatherineInCode merged commit 7467e72 into main Oct 23, 2024
@KatherineInCode KatherineInCode deleted the katherine/clean-up branch October 23, 2024 19:57
@vvolkgang vvolkgang changed the title Clean up references to the beta [PM-12269] Clean up references to the beta Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments