PM-14836: Fix vault state on app re-entry from background#1149
Merged
ezimet-livefront merged 6 commits intomainfrom Nov 23, 2024
Merged
PM-14836: Fix vault state on app re-entry from background#1149ezimet-livefront merged 6 commits intomainfrom
ezimet-livefront merged 6 commits intomainfrom
Conversation
Contributor
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1149 +/- ##
=======================================
Coverage 89.49% 89.50%
=======================================
Files 688 688
Lines 43509 43539 +30
=======================================
+ Hits 38940 38970 +30
Misses 4569 4569 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…or to have better doc and improved code
matt-livefront
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-14836
📔 Objective
This PR addresses an issue where the vault, when unlocked from the App Extension with the timeout set to "Never," does not show as unlocked in the app until it is quit and reopened. I added a new action to re-evaluate the vault's state when the app re-enters the foreground, ensuring the unlocked status is correctly reflected without needing to restart the app.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes