PM-14547: Remove soft logged out account#1150
Merged
matt-livefront merged 5 commits intomainfrom Dec 12, 2024
Merged
Conversation
Contributor
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
+ Coverage 89.47% 89.49% +0.01%
==========================================
Files 688 688
Lines 43811 43876 +65
==========================================
+ Hits 39202 39266 +64
- Misses 4609 4610 +1 ☔ View full report in Codecov by Sentry. |
fedemkr
previously approved these changes
Nov 19, 2024
ezimet-livefront
previously approved these changes
Nov 19, 2024
Collaborator
ezimet-livefront
left a comment
There was a problem hiding this comment.
⛏ just a nitpick, but looks good.
Co-authored-by: Ezimet Ozkhan <[email protected]>
7af1431
ezimet-livefront
previously approved these changes
Nov 19, 2024
| // If the active account is being removed, forward it to the router to handle | ||
| // removing the account and any navigation associated with it (e.g. switch to next | ||
| // active account). | ||
| // A user-initiated logout functions the same as removing the account. |
Contributor
There was a problem hiding this comment.
👍🏻 I appreciate this comment for additional context
| } | ||
| } | ||
|
|
||
| class MockProfileSwitcherHandlerProcessor: |
Contributor
There was a problem hiding this comment.
🤔 Would it be reasonable to break this into its own file?
Collaborator
Author
There was a problem hiding this comment.
Sure, I can move it.
KatherineInCode
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-14547
📔 Objective
When long-pressing on a logged out account in the profile switcher, the remove option should be displayed instead of log out.
📸 Screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-19.at.10.00.52.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes