Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Nov 25, 2024

🎟️ Tracking

📔 Objective

  • Updating worklfows to pass bwwl lint before deployment

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Eeebru Eeebru requested a review from a team as a code owner November 25, 2024 17:22
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Logo
Checkmarx One – Scan Summary & Details5444fb43-31c7-4c4a-a162-cf6120ba433a

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /crowdin-push.yml: 26 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (8293f41) to head (72067c5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
+ Coverage   89.39%   89.47%   +0.08%     
==========================================
  Files         688      688              
  Lines       43798    43806       +8     
==========================================
+ Hits        39152    39197      +45     
+ Misses       4646     4609      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eeebru Eeebru enabled auto-merge (squash) November 26, 2024 13:28
@Eeebru Eeebru requested a review from vvolkgang November 26, 2024 19:40
vvolkgang
vvolkgang previously approved these changes Nov 27, 2024
Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some leftover white space. Thanks for the prep changes!

@Eeebru Eeebru merged commit 0d1b52e into main Nov 29, 2024
8 checks passed
@Eeebru Eeebru deleted the BRE-443-get-major-repos-to-bwwl-lint-passing-stage branch November 29, 2024 16:58
@Eeebru Eeebru self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants