[PM-15416] Change pull-to-refresh to not force a sync#1172
[PM-15416] Change pull-to-refresh to not force a sync#1172KatherineInCode merged 6 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1172 +/- ##
=======================================
Coverage 89.39% 89.39%
=======================================
Files 688 688
Lines 43798 43798
=======================================
Hits 39152 39152
Misses 4646 4646 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
fedemkr
left a comment
There was a problem hiding this comment.
❓Sorry but I don't know much about the context on this, could more details be provided as to why this change is necessary?
BitwardenShared/UI/Vault/Vault/VaultList/VaultListProcessor.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
🤔 IMO we should change the name of the parameter isManualRefresh to something else as in this case would be contradictory given that the user is actually manually refreshing the vault. I would use forceSync as in the end is what internally is being treated as in the repositories.
Same applies to Send processor and Vault+Send repositories.
|
What exactly is this PR doing? I have noticed on my ios app (2024.12) my vault is not syncing when I pull down gesture on the vault. If I go to settings/other and click Sync Now it syncs. I am running a self hosted and also have a BW cloud account, I can reproduce in both places. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15416
📔 Objective
This changes the behavior of pull-to-refresh to respect time gates and other business logic around when we should actually do a refresh. It does not change the behavior of other places we trigger a manual refresh.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes