PM-16148: Add generator's segmented control for generator types#1237
Merged
matt-livefront merged 7 commits intomainfrom Jan 7, 2025
Merged
PM-16148: Add generator's segmented control for generator types#1237matt-livefront merged 7 commits intomainfrom
matt-livefront merged 7 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
==========================================
- Coverage 89.57% 89.53% -0.04%
==========================================
Files 709 711 +2
Lines 45082 45145 +63
==========================================
+ Hits 40382 40422 +40
- Misses 4700 4723 +23 ☔ View full report in Codecov by Sentry. |
Contributor
|
No New Or Fixed Issues Found |
fedemkr
reviewed
Jan 6, 2025
Member
fedemkr
left a comment
There was a problem hiding this comment.
Awesome job! Just one comment.
fedemkr
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-16148 - Display segmented control within generator navigation bar
PM-16137 - Update generator view for Password selection
PM-16138 - Update generator view for Passphrase selection
PM-16139 - Update generator view for username selection
📔 Objective
Adds a segmented control to the generator's navigation bar for selecting the generator type.
📸 Screenshots
Username generator from add item:
Password generator from add item:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes