[PM-16693] Add Learn More link to Email Access View#1241
Merged
KatherineInCode merged 10 commits intomainfrom Jan 6, 2025
Merged
[PM-16693] Add Learn More link to Email Access View#1241KatherineInCode merged 10 commits intomainfrom
KatherineInCode merged 10 commits intomainfrom
Conversation
Contributor
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1241 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 719 719
Lines 45429 45465 +36
=======================================
+ Hits 40729 40762 +33
- Misses 4700 4703 +3 ☔ View full report in Codecov by Sentry. |
fedemkr
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16693
📔 Objective
This adds a "learn more" link to the Email Access View. To accomplish this, I've also added the ability to pass in information for a
Buttoninto thePageHeaderView; unfortunately, I was unable to figure out how to do this with passing in an actualButtonobject (or arbitraryView), so I went with astructwith the necessary information. I would love at some point in the future to swing back around and make this more robust.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes