Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

[PM-16687] Sync before determining if we need 2FA notice#1251

Merged
KatherineInCode merged 5 commits intomainfrom
pm-16687/sync-more-often
Jan 10, 2025
Merged

[PM-16687] Sync before determining if we need 2FA notice#1251
KatherineInCode merged 5 commits intomainfrom
pm-16687/sync-more-often

Conversation

@KatherineInCode
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16687

📔 Objective

One issue with the two-factor notice is that if the user updates their two-factor authentication then returns to the app, it could still take up to 30 minutes for the fact that they now have 2FA set up to sync. This overrides that by 1) erasing the last sync time so we no longer have to wait for 30 minutes, and 2) doing a sync before determining if we should show the notice, to make sure we have the latest information about the user.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Logo
Checkmarx One – Scan Summary & Details596078c6-f096-4fb3-b5a9-334d4087bac2

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode marked this pull request as ready for review January 9, 2025 19:34
@KatherineInCode KatherineInCode merged commit 34cbcf6 into main Jan 10, 2025
6 checks passed
@KatherineInCode KatherineInCode deleted the pm-16687/sync-more-often branch January 10, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants