[PM-16687] Sync before determining if we need 2FA notice#1251
Merged
KatherineInCode merged 5 commits intomainfrom Jan 10, 2025
Merged
[PM-16687] Sync before determining if we need 2FA notice#1251KatherineInCode merged 5 commits intomainfrom
KatherineInCode merged 5 commits intomainfrom
Conversation
…wo-factor notice not show up
Contributor
|
No New Or Fixed Issues Found |
matt-livefront
approved these changes
Jan 10, 2025
fedemkr
reviewed
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16687
📔 Objective
One issue with the two-factor notice is that if the user updates their two-factor authentication then returns to the app, it could still take up to 30 minutes for the fact that they now have 2FA set up to sync. This overrides that by 1) erasing the last sync time so we no longer have to wait for 30 minutes, and 2) doing a sync before determining if we should show the notice, to make sure we have the latest information about the user.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes