[PM-24290] Improve autofill cipher lists performance #1939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….combinedSingleSection modes by applying the refactor to use the data/section builders.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1939 +/- ##
==========================================
+ Coverage 81.29% 81.33% +0.03%
==========================================
Files 822 823 +1
Lines 52015 52136 +121
==========================================
+ Hits 42284 42403 +119
- Misses 9731 9733 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
# Conflicts: # Bitwarden.xcworkspace/xcshareddata/swiftpm/Package.resolved
Comment on lines
41
to
43
| guard !ciphers.isEmpty else { return VaultListData() } | ||
|
|
||
| guard let preparedData = try await vaultListDataPreparator.prepareAutofillCombinedSingleData( |
Collaborator
There was a problem hiding this comment.
⛏️ It looks like prepareAutofillCombinedSingleData also does this isEmpty check. Is it worth eliminating this one?
| let cipherMatchingHelper = await cipherMatchingHelperFactory.make(uri: uri) | ||
|
|
||
| var preparedDataBuilder = vaultListPreparedDataBuilderFactory.make() | ||
| let restrictedOrganizationIds: [String] = await prepareRestrictedOrganizationIds(builder: preparedDataBuilder) |
Collaborator
There was a problem hiding this comment.
⛏️ Can the type be inferred here?
Suggested change
| let restrictedOrganizationIds: [String] = await prepareRestrictedOrganizationIds(builder: preparedDataBuilder) | |
| let restrictedOrganizationIds = await prepareRestrictedOrganizationIds(builder: preparedDataBuilder) |
| let cipherMatchingHelper = await cipherMatchingHelperFactory.make(uri: uri) | ||
|
|
||
| var preparedDataBuilder = vaultListPreparedDataBuilderFactory.make() | ||
| let restrictedOrganizationIds: [String] = await prepareRestrictedOrganizationIds(builder: preparedDataBuilder) |
Collaborator
There was a problem hiding this comment.
⛏️
Suggested change
| let restrictedOrganizationIds: [String] = await prepareRestrictedOrganizationIds(builder: preparedDataBuilder) | |
| let restrictedOrganizationIds = await prepareRestrictedOrganizationIds(builder: preparedDataBuilder) |
Comment on lines
148
to
152
| guard let id = cipher.id else { | ||
| return self | ||
| } | ||
|
|
||
| guard let cipherRaw = try await cipherService.fetchCipher(withId: id) else { return self } |
Collaborator
There was a problem hiding this comment.
⛏️ Could we combine these guards?
matt-livefront
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-24290
📔 Objective
Improve autofill cipher lists performance on
.passwordsand.combinedSingleSectionmodes by applying the refactor to use the data/section builders.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes