Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@KatherineInCode
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26064

📔 Objective

This consolidates a handful of lesser-used components into BitwardenKit, as part of a broader effort to move our various components into BitwardenKit. This also updates the components in BWA.

📸 Screenshots

Before After
Simulator Screenshot - iPhone 17 Pro - 2025-10-13 at 12 18 25 Simulator Screenshot - iPhone 17 Pro - 2025-10-13 at 12 19 08

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details48697aed-7106-427b-b8fe-9828dbf86662

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.93%. Comparing base (af42bd4) to head (bd9c7ff).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...atform/Application/Views/BitwardenUITextView.swift 50.00% 6 Missing ⚠️
...atform/Application/Views/SearchNoResultsView.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2036      +/-   ##
==========================================
- Coverage   85.25%   82.93%   -2.32%     
==========================================
  Files        1690     1993     +303     
  Lines      143833   160996   +17163     
==========================================
+ Hits       122620   133529   +10909     
- Misses      21213    27467    +6254     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode marked this pull request as ready for review October 13, 2025 20:10
@KatherineInCode KatherineInCode merged commit 9a81338 into main Oct 13, 2025
12 checks passed
@KatherineInCode KatherineInCode deleted the pm-26064/more-components branch October 13, 2025 20:44
kevinrossen pushed a commit to kevinrossen/bitwarden_ios that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants