[PM-27045] Explicitly specify unlock method #2047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatherineInCode
commented
Oct 16, 2025
| .toggleStyle(.bitwarden) | ||
| } | ||
|
|
||
| private func biometricsToggleText(_ biometryType: BiometricAuthenticationType) -> String { |
Contributor
Author
There was a problem hiding this comment.
🤔 This doesn't have all of the methods that PM does; in practice, all of the biometrics service code should be consolidated in BitwardenKit, and I've created PM-27047 for that.
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2047 +/- ##
==========================================
- Coverage 85.28% 82.94% -2.35%
==========================================
Files 1690 1991 +301
Lines 144061 160991 +16930
==========================================
+ Hits 122862 133532 +10670
- Misses 21199 27459 +6260 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fedemkr
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-27045
📔 Objective
This updates how we handle "Unlock with" strings under the hood to explicitly specify them, rather than having a variable.
There is broader work that could be done to consolidate the
BiometricsServiceandBiometricsRepositoryintoBitwardenKitand unify how those work, but that is captured in another ticket.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes