Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Oct 14, 2025

🎟️ Tracking

PM-26973

📔 Objective

Simplify and consolidate Crowdin folder structure by updating the destination path for iOS resource files from /ios-resources/ to /ios/.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested review from a team and matt-livefront as code owners October 14, 2025 20:17
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details83282717-d2ef-4c79-8134-8cd4e3595caf

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a small question that may be already addressed. Isn't this changing the inner structure in the Crowdin project?

@vvolkgang vvolkgang changed the title Consolidate Crowdin destination paths for iOS resources [PM-26973] Consolidate Crowdin destination paths for iOS resources Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.94%. Comparing base (7ccb499) to head (e8f1e18).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2042      +/-   ##
==========================================
- Coverage   85.28%   82.94%   -2.34%     
==========================================
  Files        1690     1993     +303     
  Lines      144051   161054   +17003     
==========================================
+ Hits       122851   133585   +10734     
- Misses      21200    27469    +6269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vvolkgang
Copy link
Member Author

vvolkgang commented Oct 14, 2025

Approving with a small question that may be already addressed. Isn't this changing the inner structure in the Crowdin project?

@fedemkr Yep, that's the goal. We'll just have ios/ folder in Crowdin instead of ios/ and ios-resources.

@vvolkgang vvolkgang enabled auto-merge (squash) October 14, 2025 20:34
@vvolkgang vvolkgang merged commit 8312821 into main Oct 14, 2025
12 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/crowdin-consolidation branch October 14, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants