Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

[PM-26060] Consolidate Router to BitwardenKit#2112

Merged
KatherineInCode merged 8 commits intomainfrom
pm-26060/consolidate-router
Nov 7, 2025
Merged

[PM-26060] Consolidate Router to BitwardenKit#2112
KatherineInCode merged 8 commits intomainfrom
pm-26060/consolidate-router

Conversation

@KatherineInCode
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26060

📔 Objective

This moves the Router to BitwardenKit, along with attendant objects, as part of an effort to migrate shared objects to BitwardenKit. Future PRs will bring some other core things over, which will enable bringing the Select Language UI over.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Logo
Checkmarx One – Scan Summary & Details2fc9857a-dde9-4368-b0b8-aec0f99315e3

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.67%. Comparing base (2a09b36) to head (48d1ee9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2112      +/-   ##
==========================================
- Coverage   85.23%   83.67%   -1.57%     
==========================================
  Files        1709     1975     +266     
  Lines      145502   161276   +15774     
==========================================
+ Hits       124021   134948   +10927     
- Misses      21481    26328    +4847     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode marked this pull request as ready for review November 6, 2025 19:33
@claude
Copy link

claude bot commented Nov 6, 2025

Claude Code is working…

I'll analyze this and get back to you.

View job run

@KatherineInCode KatherineInCode marked this pull request as draft November 6, 2025 19:39
Base automatically changed from pm-26060/consolidate-tab-navigator to main November 6, 2025 21:00
@KatherineInCode KatherineInCode force-pushed the pm-26060/consolidate-router branch from 8dec85a to 48d1ee9 Compare November 6, 2025 21:00
@KatherineInCode KatherineInCode marked this pull request as ready for review November 6, 2025 21:00
@KatherineInCode KatherineInCode merged commit 5e39f4f into main Nov 7, 2025
15 of 18 checks passed
@KatherineInCode KatherineInCode deleted the pm-26060/consolidate-router branch November 7, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants