fix: Don't call FinishLoadScene when customHandling (MirrorNetworking…

…#2794)

* fix: Don't call FinishLoadScene when customHandling
FinishLoadScene will be called from `UpdateScene`  if `loadingSceneAsync != null && loadingSceneAsync.isDone` and it's the responsibility of the user in their custom handler to assign `loadingSceneAsync` to something to block FinishLoadScene until that completes.

* Update Assets/Mirror/Runtime/NetworkManager.cs

Co-authored-by: vis2k <[email protected]>

MessagePacking.WrapHandler: improve error message when disconnecting …

…a connection because of exceptions. It needs to be obvious that it was disconnected, and why that's a good idea.

remove old comments

fix: Prevent m_AssetId set to empty string (MirrorNetworking#2766)

* fix: Prevent m_AssetId set to empty string
Fixes: MirrorNetworking#2765

Checks path for empty string before assigning to `m_AssetId`.

I left commented debug logs in place from testing, which was setting `NetworkIdentity.ServerOnly` on and off both in normal edit mode and prefab edit mode. In either mode, OnValdidate fires 4 times, and two of those try to set an empty string to `m_AssetId`.

* Changes as requested

* Update Assets/Mirror/Runtime/NetworkIdentity.cs

* Update NetworkIdentity.cs

Co-authored-by: vis2k <[email protected]>

NetworkServerTest: OnDataReceivedInvalidConnectionId simplified

fix NetworkClientTests.Send() test

add TODO

cherry picked preprocessor define from asset store release branch

fix: Telepathy V1.8 [2021-06-02]

- fix: Do not set timeouts on listener (fixes MirrorNetworking#2695)
- fix: MirrorNetworking#104 - ReadSafely now catches ObjectDisposedException too

add comment