Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@t0rr3sp3dr0
Copy link
Contributor

This patch fixes an infinite recursion while processing C++ Template types.

Fixes: #463

@t0rr3sp3dr0 t0rr3sp3dr0 mentioned this pull request Jun 1, 2024
2 tasks
@t0rr3sp3dr0
Copy link
Contributor Author

This also fixes an issue where structs and unions were not being parsed properly, causing missing imports.

image

@t0rr3sp3dr0
Copy link
Contributor Author

t0rr3sp3dr0 commented Jun 1, 2024

As a side effect of fixing struct and union parsing, types not handled properly by go-macho now show up as Obj-C Classes.

Before:

@interface NSDateComponents : NSObject <NSCopying, NSSecureCoding>

- (struct __CFDateComponents { struct __CFRuntimeBase { unsigned long long x0; _Atomic  x1; unsigned long long x2; } x0; struct __CFCalendar *x1; struct __CFTimeZone *x2; long long x3; long long x4; long long x5; long long x6; long long x7; long long x8; long long x9; long long x10; long long x11; long long x12; long long x13; long long x14; long long x15; long long x16; long long x17; long long x18; } *)_dateComponents;

After:

@class x1;

@interface NSDateComponents : NSObject <NSCopying, NSSecureCoding>

- (struct __CFDateComponents { struct __CFRuntimeBase { unsigned long long x0; _Atomic  x1; unsigned long long x2; } x0; struct __CFCalendar *x1; struct __CFTimeZone *x2; long long x3; long long x4; long long x5; long long x6; long long x7; long long x8; long long x9; long long x10; long long x11; long long x12; long long x13; long long x14; long long x15; long long x16; long long x17; long long x18; } *)_dateComponents;

This needs to be fixed in go-macho.

@t0rr3sp3dr0
Copy link
Contributor Author

The issue in go-macho should be address by this patch: blacktop/go-macho#58

@blacktop
Copy link
Owner

blacktop commented Jun 2, 2024

@t0rr3sp3dr0 go-macho updated, rebase?

@t0rr3sp3dr0
Copy link
Contributor Author

We also need to get this one merged: blacktop/go-macho#59

Noticed some weird @class next; stuff added to Foundation after this patch and that lead to another problem in go-macho.

@blacktop
Copy link
Owner

blacktop commented Jun 2, 2024

We also need to get this one merged: blacktop/go-macho#59

Noticed some weird @class next; stuff added to Foundation after this patch and that lead to another problem in go-macho.

done

@blacktop
Copy link
Owner

blacktop commented Jun 2, 2024

LGTM

@blacktop blacktop merged commit 843022a into blacktop:master Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error when class-dump

2 participants