-
-
Notifications
You must be signed in to change notification settings - Fork 213
fix: properly handle cpp templates #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As a side effect of fixing struct and union parsing, types not handled properly by go-macho now show up as Obj-C Classes. Before: @interface NSDateComponents : NSObject <NSCopying, NSSecureCoding>
- (struct __CFDateComponents { struct __CFRuntimeBase { unsigned long long x0; _Atomic x1; unsigned long long x2; } x0; struct __CFCalendar *x1; struct __CFTimeZone *x2; long long x3; long long x4; long long x5; long long x6; long long x7; long long x8; long long x9; long long x10; long long x11; long long x12; long long x13; long long x14; long long x15; long long x16; long long x17; long long x18; } *)_dateComponents;After: @class x1;
@interface NSDateComponents : NSObject <NSCopying, NSSecureCoding>
- (struct __CFDateComponents { struct __CFRuntimeBase { unsigned long long x0; _Atomic x1; unsigned long long x2; } x0; struct __CFCalendar *x1; struct __CFTimeZone *x2; long long x3; long long x4; long long x5; long long x6; long long x7; long long x8; long long x9; long long x10; long long x11; long long x12; long long x13; long long x14; long long x15; long long x16; long long x17; long long x18; } *)_dateComponents;This needs to be fixed in go-macho. |
|
The issue in go-macho should be address by this patch: blacktop/go-macho#58 |
|
@t0rr3sp3dr0 go-macho updated, rebase? |
|
We also need to get this one merged: blacktop/go-macho#59 Noticed some weird |
done |
|
LGTM |
This patch fixes an infinite recursion while processing C++ Template types.
Fixes: #463