Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CSG recursion depth limit #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

CSG recursion depth limit #282

merged 3 commits into from
Apr 30, 2025

Conversation

@ConorStokes
Copy link
Contributor

Changes to allow limiting the CSG recursion depth, including for viewers.

Adds hard limiting of CSG recursion depth, including in viewer components and the ifc command line tool, with a configurable maximum depth (default 20).

@ConorStokes ConorStokes added the enhancement New feature or request label Apr 16, 2025
@ConorStokes ConorStokes self-assigned this Apr 16, 2025
nickcastel50
nickcastel50 approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

IFC Regression Results

Failed.csv:
No failures ✅

Errors.csv:

message count expressids file
Error extracting firstOperand geometry for 1 200 - type: IFCBLOCK - isRelVoid: False bath-csg-solid.ifc
Found null for nonnullable field IfcReflectanceMethodEnum. 9 4035 4370 39964 41778 43835 42027 63478 66593 81593 ISSUE_034_HouseZ.ifc
Invalid STEP detected in parse, but no syntax error detected 1 ISSUE_098_R8_F1_MAB_AR_M3_XX_XXX_MO_7000.IFC
No IfcProjects found? 1 ISSUE_098_R8_F1_MAB_AR_M3_XX_XXX_MO_7000.IFC
bad bound 1 2 61 ISSUE_102_M3D-CON-CD.ifc
No basis found for brep! 12 ISSUE_126_model.ifc
Error processing relAggregate 14 370003, error: Value in STEP was incorrectly typed 43, error: Value in STEP was incorrectly typed 44, error: Value in STEP was incorrectly typed 3090003, error: Value in STEP was incorrectly typed 11280003, error: Value in STEP was incorrectly typed 14100003, error: Value in STEP was incorrectly typed 23420003, error: Value in STEP was incorrectly typed 31610003, error: Value in STEP was incorrectly typed 34300003, error: Value in STEP was incorrectly typed 36990003, error: Value in STEP was incorrectly typed 39680003, error: Value in STEP was incorrectly typed 42370005, error: Value in STEP was incorrectly typed 58330003, error: Value in STEP was incorrectly typed 61020003, error: Value in STEP was incorrectly typed KIT-Simple-Road-Test-Web-IFC4x3_RC2.ifc
No basis found for brep! 48 S_Office_Integrated Design Archi.ifc
Error processing relatingMaterial 1 271790, error: Value in select must be populated ifcbridge-model01.ifc
No basis found for brep! 41 SKYLARK250_design-kit_blocks_detailed.ifc

NPM Package Artifact:
The package bldrs-ai-conway-0.18.886.tgz was generated.
Download it from this run’s artifacts page
(look for the artifact named bldrs-ai-conway-0.18.886.tgz).

@ConorStokes ConorStokes mentioned this pull request Apr 16, 2025
Merged
ConorStokes added 2 commits May 1, 2025 02:51
@ConorStokes
* Switched limited CSG depth to true by default
309b434 
* Integrated some small optimisations from compound CSG (not compound CSG itself).
@ConorStokes
* Updated to have default parameters bugs fixed in command line.
b85f34c
@github-actions
Copy link

IFC Regression Results

Failed.csv:
No failures ✅

Errors.csv:

message count expressids file
Error extracting firstOperand geometry for 1 200 - type: IFCBLOCK - isRelVoid: False bath-csg-solid.ifc
Found null for nonnullable field IfcReflectanceMethodEnum. 9 4035 4370 39964 41778 43835 42027 63478 66593 81593 ISSUE_034_HouseZ.ifc
Invalid STEP detected in parse, but no syntax error detected 1 ISSUE_098_R8_F1_MAB_AR_M3_XX_XXX_MO_7000.IFC
No IfcProjects found? 1 ISSUE_098_R8_F1_MAB_AR_M3_XX_XXX_MO_7000.IFC
bad bound 1 2 61 ISSUE_102_M3D-CON-CD.ifc
No basis found for brep! 12 ISSUE_126_model.ifc
Error processing relAggregate 14 370003, error: Value in STEP was incorrectly typed 43, error: Value in STEP was incorrectly typed 44, error: Value in STEP was incorrectly typed 3090003, error: Value in STEP was incorrectly typed 11280003, error: Value in STEP was incorrectly typed 14100003, error: Value in STEP was incorrectly typed 23420003, error: Value in STEP was incorrectly typed 31610003, error: Value in STEP was incorrectly typed 34300003, error: Value in STEP was incorrectly typed 36990003, error: Value in STEP was incorrectly typed 39680003, error: Value in STEP was incorrectly typed 42370005, error: Value in STEP was incorrectly typed 58330003, error: Value in STEP was incorrectly typed 61020003, error: Value in STEP was incorrectly typed KIT-Simple-Road-Test-Web-IFC4x3_RC2.ifc
No basis found for brep! 48 S_Office_Integrated Design Archi.ifc
Error processing relatingMaterial 1 271790, error: Value in select must be populated ifcbridge-model01.ifc
No basis found for brep! 41 SKYLARK250_design-kit_blocks_detailed.ifc

NPM Package Artifact:
The package bldrs-ai-conway-0.18.900.tgz was generated.
Download it from this run’s artifacts page
(look for the artifact named bldrs-ai-conway-0.18.900.tgz).

@ConorStokes ConorStokes merged commit efbd8ec into main Apr 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickcastel50 nickcastel50 nickcastel50 approved these changes

Assignees

@ConorStokes ConorStokes

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ConorStokes @nickcastel50