Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: empty field checks #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevenle merged 1 commit into from
Dec 16, 2025
Merged

fix: empty field checks #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions packages/root-cms/ui/utils/test-field-empty.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
import {describe, it, expect} from 'vitest';
import {Field, ObjectField} from '../../core/schema.js';
import {testFieldEmpty} from './test-field-empty.js';

describe('testFieldEmpty', () => {
const objectField: ObjectField = {
type: 'object',
fields: [
{type: 'string', id: 'foo'},
{type: 'string', id: 'bar'},
],
};

const arrayField: Field = {
type: 'array',
of: objectField,
};

describe('array', () => {
it('should return false for a plain non-empty array', () => {
const plainArray = [{foo: 'a'}, {foo: 'b'}];
expect(testFieldEmpty(arrayField, plainArray)).toBe(false);
});

it('should return true for an empty array', () => {
const emptyArray: any[] = [];
expect(testFieldEmpty(arrayField, emptyArray)).toBe(true);
});

it('should return false for a normalized non-empty array', () => {
const normalizedArray = {_array: ['id1'], id1: {foo: 'a'}};
expect(testFieldEmpty(arrayField, normalizedArray)).toBe(false);
});

it('should return true for a normalized array with empty items', () => {
const normalizedArray = {_array: ['id1'], id1: {foo: ''}};
expect(testFieldEmpty(arrayField, normalizedArray)).toBe(true);
});
});

describe('object', () => {
it('should return true for an empty object', () => {
expect(testFieldEmpty(objectField, {})).toBe(true);
});

it('should return true for an object with empty fields', () => {
expect(testFieldEmpty(objectField, {foo: '', bar: ''})).toBe(true);
});

it('should return false for an object with non-empty fields', () => {
expect(testFieldEmpty(objectField, {foo: 'hello'})).toBe(false);
});
});
});
13 changes: 12 additions & 1 deletion packages/root-cms/ui/utils/test-field-empty.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,17 @@ export function testFieldEmpty(
}
return true;
case 'array':
if (Array.isArray(value)) {
if (value.length === 0) {
return true;
}
for (const item of value) {
if (!testFieldEmpty(field.of, item, types)) {
return false;
}
}
return true;
}
if (
!isObject(value) ||
!Array.isArray(value._array) ||
Expand All @@ -64,7 +75,7 @@ export function testFieldEmpty(
return false;
}
}
return false;
return true;
case 'oneof': {
if (!isObject(value) || !value._type) {
return true;
Expand Down