feat: paginated msq list endpoint #5797
Open
+244
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jaredcwhite
approved these changes
Jan 27, 2026
Collaborator
jaredcwhite
left a comment
There was a problem hiding this comment.
Looks good @mcgarrye, just one issue leading to a failing test and type question.
|
|
||
| const getCardContent = () => { | ||
| if (!loading && data?.length === 0) return null | ||
| if (!loading && data?.meta.totalItems === 0) return null |
Collaborator
There was a problem hiding this comment.
There's a failing Cypress test because data?.meta could be undefined. Not sure what's going on with that.
| applicationSection?: MultiselectQuestionsApplicationSectionEnum | ||
| ) => { | ||
| data: SelectAndOrderSection[] | ||
| data: PaginatedMultiselectQuestion |
Collaborator
There was a problem hiding this comment.
Do we even need the SelectAndOrderSection type anymore? Seems just to be an alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the new Preferences table with V2 MSQ, we need to have metadata for pagination on the list endpoint.
This is backwards compatible and does not require a feature flag. Frontend files are update to handle receiving the metadata.
How Can This Be Tested/Reviewed?
Login to the partners site
Go to the Settings page and make sure the Preferences table loads
Create/Edit a listing
Make sure page loads
Add a Preference or Program
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: