Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Migrate codecov to GitHub Action #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2022
Merged

Migrate codecov to GitHub Action #101

merged 1 commit into from
Jan 20, 2022

Conversation

@kwridan
Copy link
Contributor

@kwridan kwridan commented Jan 20, 2022 •
edited
Loading

Describe your changes

  • The codecov bash uploader is deprecated and will no longer work starting February 2022
  • The recommendation is to migrate to an alternate uploader, in our case v2 of the GitHub codecov action

Test Plan

  • Ran make test_ci
  • Verify coverage reports are still saved to the .coverage directory

Additional context

References:

@kwridan
Migrate codecov to GitHub Action
3fef652 
- The codecov bash uploader is deprecated and will no longer work starting February 2022
- The recommendation is to migrate to an alternate uploadeer, in our case v2 of the GitHub codecov action

References:

- https://docs.codecov.com/docs/about-the-codecov-bash-uploader

Signed-off-by: Kassem Wridan <[email protected]>
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #101 (3fef652) into main (a314558) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   96.22%   96.33%   +0.11%     
==========================================
  Files          47       47              
  Lines        1853     2400     +547     
==========================================
+ Hits         1783     2312     +529     
- Misses         70       88      +18
Impacted Files Coverage Δ
Sources/XCDiffCore/Library/XcodeProjLoader.swift 66.66% <0.00%> (-19.05%) ⬇️
Sources/XCDiffCore/ProjectComparator.swift 97.72% <0.00%> (-2.28%) ⬇️
...ffCore/Comparator/ResolvedSettingsComparator.swift 98.75% <0.00%> (-1.25%) ⬇️
Sources/XCDiffCore/Library/SettingsHelper.swift 94.33% <0.00%> (-0.54%) ⬇️
Sources/XCDiff/main.swift 0.00% <0.00%> (ø)
Sources/XCDiffCommand/Utils.swift 0.00% <0.00%> (ø)
Sources/XCDiffCore/Library/Diff.swift 100.00% <0.00%> (ø)
Sources/XCDiffCore/ComparatorType.swift 100.00% <0.00%> (ø)
Sources/XCDiffCore/Library/System.swift 0.00% <0.00%> (ø)
Sources/XCDiffCore/Library/PathHelper.swift 100.00% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a314558...3fef652. Read the comment docs.

@kwridan kwridan merged commit 0a82777 into bloomberg:main Jan 20, 2022
@kwridan kwridan deleted the update/codecov-github-action branch January 20, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marciniwanicki marciniwanicki marciniwanicki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kwridan @marciniwanicki