Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feat: Added custom headers and toggle keyring CLI options #5017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feat: Added custom headers and toggle keyring CLI options #5017

wants to merge 4 commits into from

Conversation

@BlairAllan
Copy link

@BlairAllan BlairAllan commented Oct 6, 2025

Summary

Add support for custom HTTP headers and a CLI option to toggle keyring storage. Updated docs to explain how to add these headers and provided an example.

Type of Change

  • Feature

Testing

  • Added unit tests for custom headers in custom_providers.rs to verify that the headers are saved
    and loaded correctly
  • Manually tested the CLI flow for adding custom headers
  • Manually tested the keyring toggle functionality via goose configure > Settings > Secret
    Storage

@BlairAllan BlairAllan force-pushed the feat/custom-headers-keyring-config branch 2 times, most recently from ac9d599 to 564ff96 Compare October 6, 2025 00:12
@taniandjerry
Copy link
Contributor

taniandjerry commented Oct 8, 2025

Let us know when this is ready for review, or if you have questions!

DOsinga
DOsinga approved these changes Oct 11, 2025
View reviewed changes
Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@BlairAllan BlairAllan force-pushed the feat/custom-headers-keyring-config branch from 564ff96 to dffd0dd Compare October 20, 2025 19:36
@BlairAllan BlairAllan marked this pull request as ready for review October 20, 2025 19:40
@BlairAllan BlairAllan requested a review from a team as a code owner October 20, 2025 19:40
@BlairAllan BlairAllan changed the title Feature/Added custom headers and toggle keyring CLI options Feat: Added custom headers and toggle keyring CLI options Oct 21, 2025
@BlairAllan BlairAllan requested a review from DOsinga October 21, 2025 06:51
DOsinga
DOsinga approved these changes Oct 21, 2025
View reviewed changes
iandouglas
iandouglas suggested changes Oct 21, 2025
View reviewed changes
@blackgirlbytes
Copy link
Contributor

blackgirlbytes commented Oct 25, 2025

here's how to fix the DCO check

@BlairAllan BlairAllan force-pushed the feat/custom-headers-keyring-config branch 2 times, most recently from cb7b6fc to b37fb67 Compare October 25, 2025 11:52
@BlairAllan BlairAllan force-pushed the feat/custom-headers-keyring-config branch from b37fb67 to cbee07e Compare October 25, 2025 11:55
@BlairAllan BlairAllan requested a review from iandouglas October 25, 2025 12:26
@DOsinga
Copy link
Collaborator

DOsinga commented Nov 10, 2025

sorry @BlairAllan for letting this linger - there was a merge conflict I tried to fix, but we changed the interface and I think I made it worse. can you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DOsinga DOsinga DOsinga approved these changes

@iandouglas iandouglas Awaiting requested review from iandouglas

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BlairAllan @taniandjerry @blackgirlbytes @DOsinga @iandouglas