fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources #6378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…865) Fixes #6364 The draft spec SEP-1865 expects `_meta.ui.resourceUri` (nested object) but goose was expecting `_meta['ui/resourceUri']` (flat key with slash), which prevented MCP Apps UI from rendering. Updated ToolCallWithResponse.tsx to use the correct nested format.
* main: fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372)
… App resource URI
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes duplicate rendering when a tool returns both mcp-ui and mcp-apps resources by implementing conditional rendering based on the presence of an MCP App resource URI.
- Adds logic to detect MCP App resource URI in tool requests
- Makes MCP UI inline rendering and MCP App rendering mutually exclusive
- Prioritizes MCP App rendering when resource URI is present
| } | ||
|
|
||
| const requestWithMeta = toolRequest as ToolRequestWithMeta; | ||
| const hasMcpAppResourceURI = Boolean(requestWithMeta._meta?.ui?.resourceUri); |
There was a problem hiding this comment.
The check for MCP App resource URI is incomplete. McpAppWrapper (lines 89-97) checks both toolRequest._meta?.ui?.resourceUri AND toolResponse.toolResult._meta?.ui?.resourceUri as a fallback. However, this code only checks the toolRequest side, which means if the resource URI is only present in the toolResponse, both renderers will still be shown, causing the duplicate rendering issue.
Suggested change
| const hasMcpAppResourceURI = Boolean(requestWithMeta._meta?.ui?.resourceUri); | |
| const hasMcpAppResourceURI = Boolean( | |
| requestWithMeta._meta?.ui?.resourceUri || | |
| (toolResponse?.toolResult as any)?._meta?.ui?.resourceUri | |
| ); |
alexhancock
approved these changes
Jan 7, 2026
zanesq
added a commit
that referenced
this pull request
Jan 8, 2026
* 'main' of github.com:block/goose: Fixed fonts (#6389) Update confidence levels prompt injection detection to reduce false positive rates (#6390) Add ML-based prompt injection detection (#5623) docs: update custom extensions tutorial (#6388) fix ResultsFormat error when loading old sessions (#6385) docs: add MCP Apps tutorial and documentation updates (#6384) changed z-index to make sure the search highlighter does not appear on modal overlay (#6386) Handling special claude model response in github copilot provider (#6369) fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378) fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372) feat(providers): add streaming support for Google Gemini provider (#6191) Blog: edit links in mcp apps post (#6371) fix: prevent infinite loop of tool-input notifications in MCP Apps (#6374)
michaelneale
added a commit
that referenced
this pull request
Jan 8, 2026
* main: (31 commits) added validation and debug for invalid call tool result (#6368) Update MCP apps tutorial: fix _meta structure and version prereq (#6404) Fixed fonts (#6389) Update confidence levels prompt injection detection to reduce false positive rates (#6390) Add ML-based prompt injection detection (#5623) docs: update custom extensions tutorial (#6388) fix ResultsFormat error when loading old sessions (#6385) docs: add MCP Apps tutorial and documentation updates (#6384) changed z-index to make sure the search highlighter does not appear on modal overlay (#6386) Handling special claude model response in github copilot provider (#6369) fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378) fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372) feat(providers): add streaming support for Google Gemini provider (#6191) Blog: edit links in mcp apps post (#6371) fix: prevent infinite loop of tool-input notifications in MCP Apps (#6374) fix: Show platform-specific keyboard shortcuts in UI (#6323) fix: we load extensions when agent starts so don't do it up front (#6350) docs: credit HumanLayer in RPI tutorial (#6365) Blog: Goose Lands MCP Apps (#6172) Claude 3.7 is out. we had some harcoded stuff (#6197) ...
wpfleger96
added a commit
that referenced
this pull request
Jan 9, 2026
* main: (89 commits) fix(google): treat signed text as regular content in streaming (#6400) Add frameDomains and baseUriDomains CSP support for MCP Apps (#6399) fix(ci): add missing dependencies to openapi-schema-check job (#6367) feat: http proxy support Add support for changing working dir and extensions in same window/session (#6057) Sort keys in canonical models (#6403) added validation and debug for invalid call tool result (#6368) Update MCP apps tutorial: fix _meta structure and version prereq (#6404) Fixed fonts (#6389) Update confidence levels prompt injection detection to reduce false positive rates (#6390) Add ML-based prompt injection detection (#5623) docs: update custom extensions tutorial (#6388) fix ResultsFormat error when loading old sessions (#6385) docs: add MCP Apps tutorial and documentation updates (#6384) changed z-index to make sure the search highlighter does not appear on modal overlay (#6386) Handling special claude model response in github copilot provider (#6369) fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378) fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372) feat(providers): add streaming support for Google Gemini provider (#6191) Blog: edit links in mcp apps post (#6371) ...
wpfleger96
added a commit
that referenced
this pull request
Jan 9, 2026
* main: (89 commits) fix(google): treat signed text as regular content in streaming (#6400) Add frameDomains and baseUriDomains CSP support for MCP Apps (#6399) fix(ci): add missing dependencies to openapi-schema-check job (#6367) feat: http proxy support Add support for changing working dir and extensions in same window/session (#6057) Sort keys in canonical models (#6403) added validation and debug for invalid call tool result (#6368) Update MCP apps tutorial: fix _meta structure and version prereq (#6404) Fixed fonts (#6389) Update confidence levels prompt injection detection to reduce false positive rates (#6390) Add ML-based prompt injection detection (#5623) docs: update custom extensions tutorial (#6388) fix ResultsFormat error when loading old sessions (#6385) docs: add MCP Apps tutorial and documentation updates (#6384) changed z-index to make sure the search highlighter does not appear on modal overlay (#6386) Handling special claude model response in github copilot provider (#6369) fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378) fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372) feat(providers): add streaming support for Google Gemini provider (#6191) Blog: edit links in mcp apps post (#6371) ...
fbalicchia
pushed a commit
to fbalicchia/goose
that referenced
this pull request
Jan 13, 2026
…p-apps resources (block#6378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6377
When a tool returns both an mcp-ui resource AND an mcp-apps resource, the UI was rendering both, causing duplicate display.
Changes
ToolCallWithResponseto check for the presence of an MCP App resource URI (_meta.ui.resourceUri)This ensures only one rendering path is used based on whether the tool response is intended for MCP Apps or MCP UI.
Testing