Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor rollforward logic in ChainSync agents to avoid updating currentPoint in case of listener error #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Refactor rollforward logic in ChainSync agents to avoid updating currentPoint in case of listener error #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions .../main/java/com/bloxbean/cardano/yaci/core/protocol/chainsync/n2c/LocalChainSyncAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,28 +140,6 @@ private void onRollBackward(Rollbackward rollBackward) {
}

private void onRollForward(LocalRollForward rollForward) {
if (rollForward.getBlock() != null) { //For Byron era, this value is null. Will be fixed later
this.currentPoint = new Point(rollForward.getBlock().getHeader().getHeaderBody().getSlot(), rollForward.getBlock().getHeader().getHeaderBody().getBlockHash());
} else if (rollForward.getByronBlock() != null) {
this.currentPoint = new Point(rollForward.getByronBlock().getHeader().getConsensusData().getSlotId().getSlot(), rollForward.getByronBlock().getHeader().getBlockHash());
} else if (rollForward.getByronEbBlock() != null) {
this.currentPoint = new Point(0, rollForward.getByronEbBlock().getHeader().getBlockHash()); //TODO -- SlotId == 0 for ByronEbBlock ??
}

if (counter++ % 100 == 0 || (tip.getPoint().getSlot() - currentPoint.getSlot()) < 10) {

if (log.isDebugEnabled()) {
log.debug("**********************************************************");
log.debug(String.valueOf(currentPoint));
log.debug("[Agent No: " + agentNo + "] : " + rollForward);
log.debug("**********************************************************");
}

if (stopAt != 0 && rollForward.getBlock().getHeader().getHeaderBody().getSlot() >= stopAt) {
this.currenState = HandshkeState.Done;
}
}

if (rollForward.getBlock() != null) { //For shelley and later era
getAgentListeners().stream().forEach(
chainSyncAgentListener -> {
Expand All @@ -185,6 +163,28 @@ private void onRollForward(LocalRollForward rollForward) {
}
);
}

if (rollForward.getBlock() != null) { //For Byron era, this value is null. Will be fixed later
this.currentPoint = new Point(rollForward.getBlock().getHeader().getHeaderBody().getSlot(), rollForward.getBlock().getHeader().getHeaderBody().getBlockHash());
} else if (rollForward.getByronBlock() != null) {
this.currentPoint = new Point(rollForward.getByronBlock().getHeader().getConsensusData().getSlotId().getSlot(), rollForward.getByronBlock().getHeader().getBlockHash());
} else if (rollForward.getByronEbBlock() != null) {
this.currentPoint = new Point(0, rollForward.getByronEbBlock().getHeader().getBlockHash()); //TODO -- SlotId == 0 for ByronEbBlock ??
}

if (counter++ % 100 == 0 || (tip.getPoint().getSlot() - currentPoint.getSlot()) < 10) {

if (log.isDebugEnabled()) {
log.debug("**********************************************************");
log.debug(String.valueOf(currentPoint));
log.debug("[Agent No: " + agentNo + "] : " + rollForward);
log.debug("**********************************************************");
}

if (stopAt != 0 && rollForward.getBlock().getHeader().getHeaderBody().getSlot() >= stopAt) {
this.currenState = HandshkeState.Done;
}
}
}

@Override
Expand Down
48 changes: 24 additions & 24 deletions core/src/main/java/com/bloxbean/cardano/yaci/core/protocol/chainsync/n2n/ChainsyncAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,30 @@ private void onRollBackward(Rollbackward rollBackward) {
}

private void onRollForward(RollForward rollForward) {
if (rollForward.getBlockHeader() != null) { //For Shelley and later eras
getAgentListeners().stream().forEach(
chainSyncAgentListener -> {
chainSyncAgentListener.rollforward(rollForward.getTip(), rollForward.getBlockHeader());
}
);
} else if (rollForward.getByronBlockHead() != null) { //For Byron main block
if (log.isTraceEnabled())
log.trace("Byron Block: " + rollForward.getByronBlockHead().getConsensusData().getSlotId());
getAgentListeners().stream().forEach(
chainSyncAgentListener -> {
chainSyncAgentListener.rollforwardByronEra(rollForward.getTip(), rollForward.getByronBlockHead());
}
);
} else if (rollForward.getByronEbHead() != null) { //For Byron Eb block
if (log.isTraceEnabled())
log.trace("Byron Eb Block: " + rollForward.getByronEbHead().getConsensusData());
getAgentListeners().stream().forEach(
chainSyncAgentListener -> {
chainSyncAgentListener.rollforwardByronEra(rollForward.getTip(), rollForward.getByronEbHead());
}
);
}

if (rollForward.getBlockHeader() != null) { //shelley and later
this.currentPoint = new Point(rollForward.getBlockHeader().getHeaderBody().getSlot(), rollForward.getBlockHeader().getHeaderBody().getBlockHash());
} else if (rollForward.getByronBlockHead() != null) { //Byron Block
Expand All @@ -161,30 +185,6 @@ private void onRollForward(RollForward rollForward) {
this.currenState = HandshkeState.Done;
}
}

if (rollForward.getBlockHeader() != null) { //For Shelley and later eras
getAgentListeners().stream().forEach(
chainSyncAgentListener -> {
chainSyncAgentListener.rollforward(rollForward.getTip(), rollForward.getBlockHeader());
}
);
} else if(rollForward.getByronBlockHead() != null) { //For Byron main block
if (log.isTraceEnabled())
log.trace("Byron Block: " + rollForward.getByronBlockHead().getConsensusData().getSlotId());
getAgentListeners().stream().forEach(
chainSyncAgentListener -> {
chainSyncAgentListener.rollforwardByronEra(rollForward.getTip(), rollForward.getByronBlockHead());
}
);
} else if (rollForward.getByronEbHead() != null) { //For Byron Eb block
if (log.isTraceEnabled())
log.trace("Byron Eb Block: " + rollForward.getByronEbHead().getConsensusData());
getAgentListeners().stream().forEach(
chainSyncAgentListener -> {
chainSyncAgentListener.rollforwardByronEra(rollForward.getTip(), rollForward.getByronEbHead());
}
);
}
}

@Override
Expand Down