Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve c-string API #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 23, 2023
Merged

Improve c-string API #114

merged 7 commits into from
Oct 23, 2023

Conversation

@zfields
Copy link
Contributor

@zfields zfields commented Oct 20, 2023

  • standardize newline termination behavior
  • accept chain "cmd" request
  • handle string literals

@zfields zfields requested a review from haydenroche5 October 20, 2023 21:15
@zfields
Improve c-string API
bc0a20a 
- standardize newline termination behavior
- accept chain "cmd" request
- handle string literals
zfields
zfields commented Oct 23, 2023
View reviewed changes
Copy link
Contributor Author

@zfields zfields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@haydenroche5 haydenroche5 merged commit 86417e5 into master Oct 23, 2023
@haydenroche5 haydenroche5 deleted the zak-c-str branch October 23, 2023 18:53
@zfields zfields mentioned this pull request Oct 23, 2023
Closed
@haydenroche5 haydenroche5 mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haydenroche5 haydenroche5 Awaiting requested review from haydenroche5

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zfields @haydenroche5