Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@haydenroche5
Copy link
Collaborator

@haydenroche5 haydenroche5 commented Dec 11, 2022

I opted not to Dockerize this, in contrast to what's been done in note-arduino. The build already runs in a GitHub-provisioned VM, so the addition of a container inside that seems like overkill.

Zak and I talked, and I decided to go the Docker/container route in the end, for a few reasons:

  1. No hidden dependencies. For example, the GitHub VMs come with CMake installed, among other packages we need. With the Dockerfile, we fully enumerate our dependencies, so nothing is implied or hidden.
  2. Easier for developers to run the GitHub action locally. This is mainly due to 1: the container will set up whatever dependencies it needs; we don't need to install anything up front.
  3. Easier to migrate to a different CI platform if we ever outgrow GitHub actions.

One key downside is that, for the moment, we're building the Docker image anew on every CI run. When we eventually get set up with a container registry (e.g. Github's container registry), this problem will go away, as we'll be able to pull down images from the registry.

@haydenroche5 haydenroche5 self-assigned this Dec 11, 2022
@haydenroche5 haydenroche5 requested a review from zfields December 11, 2022 00:41
@m-mcgowan m-mcgowan self-requested a review December 12, 2022 20:05
Copy link
Contributor

@m-mcgowan m-mcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach, simple and to the point.

@m-mcgowan
Copy link
Contributor

Not wanting to add more to the scope, but how about adding code coverage reporting to Coveralls? You can probably borrow from the existing implementation in note-arduino, recast as CMake scripts.

@haydenroche5
Copy link
Collaborator Author

haydenroche5 commented Dec 13, 2022

Not wanting to add more to the scope, but how about adding code coverage reporting to Coveralls? You can probably borrow from the existing implementation in note-arduino, recast as CMake scripts.

That's in the works, actually. 😄 I have a branch for it on my fork. I think we can go ahead and get this merged in, and then I'll add the coverage stuff in a subsequent PR.

Copy link
Contributor

@m-mcgowan m-mcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haydenroche5 haydenroche5 merged commit c939638 into blues:master Dec 13, 2022
@haydenroche5 haydenroche5 deleted the unit_test_action branch December 13, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants