NoteSetRequestTimeout #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new function NoteSetRequestTimeout that allows dynamic configuration of request timeout values, replacing the previously hardcoded 30-second timeout. The function enables developers to set custom timeouts for specific transactions and restore the default timeout when needed.
Key changes:
- Added
NoteSetRequestTimeoutfunction with ability to set custom timeouts or restore defaults - Modified timeout mechanism to use an override variable instead of hardcoded constant
- Comprehensive test coverage for various timeout scenarios including edge cases
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/src/NoteSetRequestTimeout_test.cpp | Comprehensive test suite covering default, custom, and edge case timeout scenarios |
| test/CMakeLists.txt | Added test registration for the new timeout function tests |
| note.h | Added public function declaration for NoteSetRequestTimeout |
| n_request.c | Implemented NoteSetRequestTimeout function and added override variable |
| n_lib.h | Modified timeout macro to use override variable with fallback to default |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.