chore: handle zero length request #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables "receive only" transactions by handling zero-length requests and harmonizes the implementation between I2C and serial transaction functions.
- Adds protection against zero-length request transmission in both I2C and serial interfaces
- Harmonizes error handling and variable declarations between
_i2cNoteTransaction()and_serialNoteTransaction() - Improves the chunked transmission loop in
_serialChunkedTransmit()for better clarity and performance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| n_serial.c | Adds zero-length request handling, harmonizes error handling, and refactors chunked transmission loop |
| n_i2c.c | Adds zero-length request handling and harmonizes error handling with serial implementation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable "receive only" transactions (i.e
{heartbeat}), I needed to first ensure zero length transmissions do not cause failures. Then I also attempted to homogenize_i2cNoteTransaction()and_serialNoteTransaction().