Add unit tests to cover n_ua.c. #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix a couple problems in n_ua.c: - The logic for putting the Atollic GCC compiler in the user agent object was written such that it would never trigger. - We allow the user to set n_cpu_name via NoteSetUserAgentCPU, but then in NoteUserAgent we were overriding whatever they set it to, based on preprocessor logic. I moved that preprocessor logic out so that it controls the default value of n_cpu_name, but if the user overrides it, that's what we put in the user agent object.
- NoteFactoryReset - NoteSetProductID - NoteSetSerialNumber - NoteSetSyncMode - NoteSetUploadMode - NoteTemplate
zfields
approved these changes
Mar 7, 2023
zfields
approved these changes
Mar 7, 2023
| static char *n_cpu_vendor = NULL; | ||
|
|
||
| static char *n_cpu_name = NULL; | ||
| #if defined(ARDUINO_ARCH_ARC32) |
There was a problem hiding this comment.
Why change the whitespace? Was this done by the linter?
There was a problem hiding this comment.
Yes. astyle removed the indentation.
| char *compiler = (char *) ("gcc" PLUS " " __VERSION__); | ||
| #elif defined(__ATOLLIC__) && defined(__GNUC__) | ||
| char *compiler = (char *) ("atollic gcc" PLUS " " __VERSION__); | ||
| #elif defined(__GNUC__) |
There was a problem hiding this comment.
This change is fine, but I will take this opportunity to belly ache that I would like to see modifications performed on the underlying library as separate PRs from unit-tests.
To me it seems cleaner, and maintains the separation of church and state.
There was a problem hiding this comment.
I'm fine with that going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix a couple problems in n_ua.c: