Clarify NoteRequest return when sending 'cmd' #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thought that occurs to me is whether NoteRequest() should check for an error response if sending a This would add value in a situation where a critical cmd (such as a card.attn with a payload) is sent - but it's probably low priority since when the host sends a critical |
Clarify in function comments that a `true` return value from NoteRequest when sending a `cmd` indicates that the `cmd` was sent without error, but does not guarantee that the Notecard received and processed the `cmd`. The application should make other provisions to determine that the `cmd` was processed if this is critical to system behavior.
370bf00 to
90788a1
Compare
zfields
reviewed
Mar 30, 2023
zfields
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify in function comments that a
truereturn value from NoteRequest when sending acmdindicates that thecmdwas sent without error, but does not guarantee that the Notecard received and processed thecmd.The application should make other provisions to determine that the
cmdwas processed if this is critical to system behavior.