Fix required CMake version #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`VERSION_GREATER_EQUAL` was introduced in 3.7
ned14
added a commit
to ned14/outcome
that referenced
this pull request
Oct 8, 2025
ned14
added a commit
to ned14/outcome
that referenced
this pull request
Oct 8, 2025
…Also bump minium cmake to 3.10 everywhere else in Outcome, as CI is now failing due to us requested too old a cmake. #314 Replaces boostorg/outcome#8
ned14
added a commit
to ned14/outcome
that referenced
this pull request
Oct 8, 2025
…Also bump minium cmake to 3.10 everywhere else in Outcome, as CI is now failing due to us requested too old a cmake. #314 Replaces boostorg/outcome#8
3.8 is the minimum now required for Boost and 3.31 the last 3.x version before 4.0
ned14
added a commit
that referenced
this pull request
Oct 9, 2025
- Bump Boost min cmake required to 3.10 to match standalone Outcome. Also bump minium cmake to 3.10 everywhere else in Outcome, as CI is now failing due to us requested too old a cmake. #314 Replaces #8
ned14
added a commit
that referenced
this pull request
Oct 9, 2025
- Bump Boost min cmake required to 3.10 to match standalone Outcome. Also bump minium cmake to 3.10 everywhere else in Outcome, as CI is now failing due to us requested too old a cmake. #314 Replaces #8
|
Fixed. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERSION_GREATER_EQUALwas introduced in 3.7: https://cmake.org/cmake/help/latest/command/if.html#version-greater-equal