Feature/ajax cart improvements #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the .remove class to the button to work with the js that gtm4wp is using. as the class is also present in the storefront theme i assume that could add compatibility to other plugins as well. Ovewrites to some woocommerce css classes had to be done to keep the original styling
Moves the `force_fragments_refresh` check to the top of the success function, and allows it to trigger even on unsuccessful responses as well.
The previous implementation of the quantity update triggered events before the cart fragments were fully updated because startViewTransition runs asynchronously. Therefore the update events where moved to run always after the updates of the cart happen.
Separates the cart item removal logic from the quantity update logic. This improves code clarity and addresses potential issues with plugins that modify the cart after quantity changes. Handles cases where plugins might remove or alter cart items after a quantity update, ensuring correct cart behavior and fragment updates. Also fixes a bug where the max quantity check was performed when removing items.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the AJAX cart functionality to fix timing issues with quantity update events on modern browsers and improves compatibility with GTM4WP tracking. The key changes move event triggers into the updateCartFragments function to handle asynchronous execution properly when using startViewTransition, and consolidate cart item removal logic to use the same code path as quantity updates.
Key Changes:
- Fixed premature
qty_updatedevent firing by moving event triggers intoupdateCartFragmentsto handle async execution withstartViewTransition - Refactored quantity update to handle removal (qty=0) within the same function instead of separate logic paths
- Added "remove" CSS class to cart item remove button for GTM4WP compatibility
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| woocommerce/js/ajax-cart.js | Restructured success/failure handling and moved event triggers into updateCartFragments to fix async timing issues |
| woocommerce/inc/ajax-cart.php | Consolidated removal logic into quantity update function, added WPML compatibility check, and adjusted notice types |
| woocommerce/cart/mini-cart-item.php | Added "remove" class to remove button for GTM4WP tracking compatibility |
| assets/scss/bootscore-woocommerce/_wc-ajax-cart.scss | Added styles to reset WooCommerce default remove button appearance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1061