-
-
Notifications
You must be signed in to change notification settings - Fork 109
Check for missing escape #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for missing escape #1133
Conversation
I've checked code to add missing escape where codex suggest use. Need check!
Fix for escape with html
|
Thank you!
Yes, it's useful. Unfortunately it's almost impossible to check every change, because there is no script to test every filter. However, I've checked it rough with some heavily modified themes through filters, and at first glance it seems to work fine. So yes, i think we should merge this. In all changed files you will find in the file header a version that should be changed from Opening a PR with 46 changed files often leads into conflicts with other PR's which is luckily for now not the case but can happen soon. So, what i want to say is that we should merge this soon before it has conflicts with other PR's/branches. If you are happy with the overall changes and updated the files version, I agree and merge. |
Update version of edited file to 6.3.1
|
Hi @crftwrk I've updated file version! |
|
i pushed also a commit that uses
I have deeply checked and found no issues, great work! But impossible to check every filter, so maybe we will find some issues later. I have sent you 2 child-themes via WeTransfer, which have a heavy usage of almost all filters. If they have no issues, this PR should be fine. I am fine here now. If you are fine as well, we can merge this. Thank you! |
crftwrk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
… synced patterns
I've checked the code to add missing escaping where the Codex suggests its use.
Please, if you think it’s useful, check all changes before merging, because I might make mistakes in some places where HTML can be used.
Regards!