Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@massimoghm
Copy link
Contributor

I've checked the code to add missing escaping where the Codex suggests its use.
Please, if you think it’s useful, check all changes before merging, because I might make mistakes in some places where HTML can be used.
Regards!

I've checked code to add missing escape where codex suggest use.
Need check!
Fix for escape with html
@crftwrk crftwrk self-requested a review November 28, 2025 10:15
@crftwrk crftwrk added this to v6.4.0 Nov 28, 2025
@crftwrk crftwrk moved this to In Progress in v6.4.0 Nov 28, 2025
@crftwrk
Copy link
Member

crftwrk commented Nov 28, 2025

Thank you!

Please, if you think it’s useful, check all changes before merging, because I might make mistakes in some places where HTML can be used.

Yes, it's useful. Unfortunately it's almost impossible to check every change, because there is no script to test every filter. However, I've checked it rough with some heavily modified themes through filters, and at first glance it seems to work fine. So yes, i think we should merge this.

In all changed files you will find in the file header a version that should be changed from @version 6.x.x into @version 6.3.1, are you able to change this?

Opening a PR with 46 changed files often leads into conflicts with other PR's which is luckily for now not the case but can happen soon. So, what i want to say is that we should merge this soon before it has conflicts with other PR's/branches. If you are happy with the overall changes and updated the files version, I agree and merge.

Update version of edited file to 6.3.1
@massimoghm
Copy link
Contributor Author

Hi @crftwrk I've updated file version!

@crftwrk
Copy link
Member

crftwrk commented Nov 28, 2025

@massimoghm,

i pushed also a commit that uses Template Version: 6.x.x instead @version 6.x.x for template files.

  • It's the default WP codex
  • Let's quick view if that is a template or a function file
  • Allows us to add a script that check if there are outdated templates in child and shows a warning in the backend

I have deeply checked and found no issues, great work! But impossible to check every filter, so maybe we will find some issues later.

I have sent you 2 child-themes via WeTransfer, which have a heavy usage of almost all filters. If they have no issues, this PR should be fine.

I am fine here now. If you are fine as well, we can merge this.

Thank you!

crftwrk
crftwrk previously approved these changes Nov 28, 2025
Copy link
Member

@crftwrk crftwrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@crftwrk crftwrk merged commit d0fca0a into bootscore:main Nov 29, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in v6.4.0 Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants