Fix typos #5597
Fix typos #5597
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5597 +/- ##
==========================================
- Coverage 83.30% 83.26% -0.04%
==========================================
Files 38 38
Lines 10119 10119
Branches 1678 1678
==========================================
- Hits 8430 8426 -4
- Misses 1190 1194 +4
Partials 499 499
Continue to review full report at Codecov.
|
Glad you appreciated it! Well, I checked all the files in git. I'm going to check if something were excluded in the commit. |
|
What I meant with "fixed at other places" is that you actually did fix it, but not at right place:
See my comments in the review. |
|
Thanks a lot for your reply.
Sorry, I don't understand the problem.
About first point, look here:
:) gelma /tmp/test $ git clone --depth=1
https://github.com/borgbackup/borg.git
Cloning into 'borg'...
remote: Enumerating objects: 447, done.
remote: Counting objects: 100% (447/447), done.
remote: Compressing objects: 100% (423/423), done.
remote: Total 447 (delta 56), reused 124 (delta 5), pack-reused 0
Receiving objects: 100% (447/447), 2.95 MiB | 1.08 MiB/s, done.
Resolving deltas: 100% (56/56), done.
:) gelma /tmp/test $ cd borg/
✔ /tmp/test/borg [master|✔]
20:21 $ git grep -Iiw ommitted|cat
docs/man/borg-compact.1:given by the \fB\-\-threshold\fP option. If
ommitted, a threshold of 10% is used.
docs/usage/compact.rst.inc:given by the ``--threshold`` option. If
ommitted, a threshold of 10% is used.
src/borg/archiver.py: given by the ``--threshold`` option. If
ommitted, a threshold of 10% is used.
Every "ommitted" has been corrected, so I dunno where else I could fix it.
In comment you tell me about archiver.py,
but fixes are already there.
To let me understand, please tell a word that is not fixed in all places.
About point two, I asked you in the comment if you want/prefer I drop the
patches on 3d party files.
Thanks a lot,
Andrea
Il giorno dom 27 dic 2020 alle ore 19:52 TW <[email protected]> ha
scritto:
… What I meant with "fixed at other places" is that you actually did fix it,
but not at right place:
- either in a generated file (needs fix in source file)
- upstream (3rd party stuff we just copy)
See my comments in the review.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5597 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACXCMYABYIJE4Q2HHVYBCTSW57ABANCNFSM4VKG3KYQ>
.
|
|
@Gelma can you finish this or shall I help with it? |
|
Looks like @Gelma is busy otherwise, so I'll finish this myself now. |
48d7573 to
72e7c46
Compare
|
^^ rebased on current master, no content change, force pushed. |
this stuff will be auto-generated, regularly done at release time.
all algorithms/* stuff needs to be fixed upstream. we just copy the files from there now and then. https://github.com/lz4/lz4 https://github.com/facebook/zstd https://github.com/Cyan4973/xxHash
|
i now also created separate diffs for the upstream projects: zstd, lz4 and xxh64 - will try to submit it there. |
|
Needs checking whether these typos are also in 1.1-maint. If applicable, only the overall diff over all 3 commits should be applied in a single commit. |
|
Note: backport this AFTER backporting:
|
Fix typos (backport of #5597)
Hi everyone,
and thanks a lot for your work.
Here's a stupid patch to fix a few typos.
Thanks again,
Gelma