HybridFactorGraph base class and other niceties #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass of HybridFactor
Nonlinear Hybrid
Linear HybridBayesNet optimization
Collaborator
|
CI is failing |
Contributor
Author
|
That's because of the Ubuntu 18.04 brownout. Should work now. |
ProfFan
reviewed
Aug 22, 2022
| TestResult tr; | ||
| return TestRegistry::runAllTests(tr); | ||
| } | ||
| /* ************************************************************************* */ No newline at end of file |
ProfFan
approved these changes
Aug 22, 2022
Collaborator
ProfFan
left a comment
There was a problem hiding this comment.
Approving sans two comments
| using Base::add; | ||
|
|
||
| /// Add a discrete conditional to the Bayes Net. | ||
| void add(const DiscreteKey &key, const std::string &table) { |
Collaborator
There was a problem hiding this comment.
I am not in favor of more helpers, do we have similar stuff in DiscreteBayesNet?
Contributor
Author
There was a problem hiding this comment.
We'll need this since we need to wrap the DiscreteConditional into a HybridConditional.
| TestResult tr; | ||
| return TestRegistry::runAllTests(tr); | ||
| } | ||
| /* ************************************************************************* */ No newline at end of file |
Contributor
Author
Hybrid Pruning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made
HybridFactorGrapha base class forHybridGaussianFactorGraphand forHybridNonlinearFactorGraphwhich will be added in a later PR. This way, the code is more DRY and mirrors the inheritance structure of the[Nonlinear|Gaussian]FactorGraphclasses.Refactored tests for
HybridGaussianFactorGraphto make them much more descriptive and to actually test things.Also added tests and improvements to
HybridBayesNet.