Add vcpkg ci #2164
Add vcpkg ci #2164
Conversation
20d9255 to
fece22c
Compare
|
Adding Dr. Fan to review this |
ProfFan
left a comment
There was a problem hiding this comment.
Thank you! Mostly looks good to me, just need a few changes :)
| binary_cache: C:\Users\runneradmin\AppData\Local\vcpkg\archives | ||
| vcpkg_info: C:/vcpkg/installed/vcpkg/info/* | ||
| python: python | ||
| ctest_extra_flags: -E check_constraint_program |
There was a problem hiding this comment.
Add a TODO before this line saying why this one has to be disabled?
There was a problem hiding this comment.
this test is failed on windows. On the regular windows build, the test is not running, so you don't aware it fail on windows.
I will add a TODO.
wrap/pybind11/CMakeLists.txt
Outdated
| set(PYBIND11_MASTER_PROJECT OFF) | ||
| set(pybind11_system SYSTEM) | ||
| set(_pybind11_findpython_default OFF) | ||
| if(CMAKE_VERSION VERSION_LESS "3.18") |
There was a problem hiding this comment.
We vendor pybind11 but we don't make changes directly on it. Could you explain why this change is required? If absolutely required this should be submitted upstream or as a VCPKG patch, and we add an option in wrap to use system or vcpkg-provided pybind11
There was a problem hiding this comment.
I agree, I don't suppose to change the wrapper. I notice that after your comment.
I did it to support vcpkg.
I already install pybind via vcpkg, and ideal gtsam should find vcpkg pybind instead this wrapper.
For now I will disable python tests in vcpkg, and revert this change.
We can explore python test with vcpkg in other PR.
There was a problem hiding this comment.
Sounds good, Just remove changes in wrap and comment out the Python VCPKG tests, and add a TODO. I'll find some time to update wrap to allow external Pybind11.
| binary_cache: C:\Users\runneradmin\AppData\Local\vcpkg\archives | ||
| vcpkg_info: C:/vcpkg/installed/vcpkg/info/* | ||
| python: python | ||
| ctest_extra_flags: -E check_constraint_program |
There was a problem hiding this comment.
this test is failed on windows. On the regular windows build, the test is not running, so you don't aware it fail on windows.
I will add a TODO.
wrap/pybind11/CMakeLists.txt
Outdated
| set(PYBIND11_MASTER_PROJECT OFF) | ||
| set(pybind11_system SYSTEM) | ||
| set(_pybind11_findpython_default OFF) | ||
| if(CMAKE_VERSION VERSION_LESS "3.18") |
There was a problem hiding this comment.
I agree, I don't suppose to change the wrapper. I notice that after your comment.
I did it to support vcpkg.
I already install pybind via vcpkg, and ideal gtsam should find vcpkg pybind instead this wrapper.
For now I will disable python tests in vcpkg, and revert this change.
We can explore python test with vcpkg in other PR.
Add vcpkg ci
Fix #672
continue this PR #1413