Created jupyter notebook for the LQR example. #2160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think we discussed some changes in our meeting? |
…nk to colab runtime. Added visualization of the factor graph and Bayes net (obtained from different elimination ordering).
Contributor
Author
|
I have made several refinements to the previous version, including: |
Member
|
I still think the ordering should be reversed and match the blog post, to indicate the DAG encodes policies P(u|x) |
…n ordering in visualization and markdown text
Member
|
The ordering in cell 20 is still wrong :-/ |
dellaert
reviewed
Jul 25, 2025
Member
dellaert
left a comment
There was a problem hiding this comment.
I know you fixed the ordering in our meeting but maybe you did not commit/push yet?
…nal website. Reviewing of code.
dellaert
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the OSPO internship, I created the notebook for a LQR example based on the legacy website post (https://gtsam.org/2019/11/07/lqr-control.html).