CI Improvements for speed #2229
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reduces CI resource usage by consolidating Boost installations to only two specific jobs - one on macOS and one on Linux. The changes remove redundant Boost installations across multiple jobs while maintaining test coverage through dedicated Boost-enabled configurations.
Key changes:
- Remove all Boost-related configurations from
build-special.ymlworkflow - Add dedicated Boost-enabled jobs to macOS and Linux workflows
- Change default Boost configuration to disabled in the build script
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/build-special.yml |
Removes ubuntu-no-boost job and all Boost installation/configuration steps |
.github/workflows/build-macos.yml |
Adds macos-14-xcode-15.4-boost job with conditional Boost installation |
.github/workflows/build-linux.yml |
Adds ubuntu-24.04-clang-16-boost job with conditional Boost installation |
.github/scripts/unix.sh |
Changes default Boost configuration from ON to OFF |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
another suggestion to speed up runs, is let vcpkg also run on push, like deploy workflow. https://github.com/borglab/gtsam/blob/develop/.github/workflows/deploy.yml#L5-L7 |
|
Happy to do so, @talregev ! What change would I make in which workflow? |
I will make another PR and we can discuss it there. |
| For reviewing PRs: | ||
| * All functions in header files should have doxygen-style API docs | ||
| * Use /// for single-line comments rather than /** */ | ||
| * Use meaningful variable names, e.g. `measurement` not `msm`, avoid abbreviations. |
There was a problem hiding this comment.
This could be even "enforced" by using clang-tidy if so wanted at some point...
New configuration of the workflows to speed up CI (and emit less CO2):
The build-special.yml workflow will not install or run Boost in any of its runs now.
Also: