Fix unique index constraint failure on item destroy#313
Merged
brendon merged 1 commit intobrendon:masterfrom Jun 5, 2018
Merged
Fix unique index constraint failure on item destroy#313brendon merged 1 commit intobrendon:masterfrom
brendon merged 1 commit intobrendon:masterfrom
Conversation
Owner
|
Looks good to me! Thanks @yjukaku :D |
Owner
|
Released as 0.9.13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing on the work from #246, but this time applying the idea to the
destroycallbacks.With this fix, destroying an item in a list that has a unique DB constraint on the position column should not raise a DB error, as long as the
sequential_updatesoption is enabled.Fixes #267