Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix dual stack IPv4/IPv6 support on docker with uvicorn#99

Merged
nikazzio merged 5 commits intobrevia-ai:mainfrom
stefanorosanelli:fix/dual-stack-uvicorn
May 26, 2025
Merged

Fix dual stack IPv4/IPv6 support on docker with uvicorn#99
nikazzio merged 5 commits intobrevia-ai:mainfrom
stefanorosanelli:fix/dual-stack-uvicorn

Conversation

@stefanorosanelli
Copy link
Contributor

@stefanorosanelli stefanorosanelli commented May 25, 2025

This PR fixes a problem in dual stack mode (combined IPv4/IPv6) on the socket used by Uvicorn, which can be important in environments in which both IP versions are supported.
This can be shown in the default docker image - see this discussion and this comment

FastAPI and Uvicorn have been upgraded to the latest versions and now when using the new docker image dual stack mode is working as expected.

@stefanorosanelli stefanorosanelli requested a review from Copilot May 26, 2025 07:52
@stefanorosanelli stefanorosanelli changed the title Fix/dual stack uvicorn Fix dual stack ipv4/ipv6 on docker with uvicorn May 26, 2025
@stefanorosanelli stefanorosanelli changed the title Fix dual stack ipv4/ipv6 on docker with uvicorn Fix dual stack ipv4/ipv6 supporto on docker with uvicorn May 26, 2025
@stefanorosanelli stefanorosanelli changed the title Fix dual stack ipv4/ipv6 supporto on docker with uvicorn Fix dual stack ipv4/ipv6 support on docker with uvicorn May 26, 2025
@stefanorosanelli stefanorosanelli changed the title Fix dual stack ipv4/ipv6 support on docker with uvicorn Fix dual stack IPv4/IPv6 support on docker with uvicorn May 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency versions to support dual-stack networking in Uvicorn.

  • Bumps FastAPI from 0.104.1 to 0.115.12 for compatibility with newer Uvicorn features.
  • Consolidates the Uvicorn dependency into a single inline entry with extras.
Files not reviewed (1)
  • Dockerfile: Language not supported
Comments suppressed due to low confidence (2)

pyproject.toml:37

  • Consider adding an integration test or CI step to validate that Uvicorn correctly binds IPv4 and IPv6 addresses to ensure dual-stack functionality works as expected.
uvicorn = {version = "^0.34.2", extras = ["standard"]}

pyproject.toml:17

  • FastAPI was bumped from version 0.104.1 to 0.115.12, which may include breaking changes in 0.x releases. Please verify compatibility by running the full test suite and updating any deprecated endpoints or behaviors.
fastapi = "^0.115.12"

@stefanorosanelli stefanorosanelli marked this pull request as ready for review May 26, 2025 08:04
@stefanorosanelli stefanorosanelli requested a review from nikazzio May 26, 2025 08:25
@nikazzio nikazzio merged commit 127a9a8 into brevia-ai:main May 26, 2025
10 checks passed
@stefanorosanelli stefanorosanelli deleted the fix/dual-stack-uvicorn branch May 28, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants