Output exit result to stderr instead of stdout to allow pipelines#9176
Output exit result to stderr instead of stdout to allow pipelines#9176pontushojer wants to merge 1 commit intobroadinstitute:masterfrom
Conversation
|
@cmnbroad Do you remember why we never changed this? Was there a reason or did it just get lost? It makes sense to me... |
|
@lbergelson I'm not sure - the change seems fine - although it will affect more than just Picard tool paths. It seems wrong as is though. |
|
Oh, right.. That was the reason. Some GATK tools return their results this way so changing it to stdout globally would cause issues there. I think there was a reason we also didn't change it to just use the return code from picard tools specifically as the return code of the process. Maybe because it violated the defined return codes GATK tools promise to honor? It does seem pretty wrong though. |
|
Maybe we should output to STDERR but only for picard tools. |
|
Thanks for the context and input! This was my naive PR as someone not at all familiar with the codebase :)
That would be fine by me. My main intention was to enable piping with picard tools. |
fix #5790, #7080
Hi!
The exit codes from picard tools are written to stdout which messes up pipelines. In my case, I want to be able to pipe MarkDuplicates to output using
-O /dev/stdoutbut the stream gets messed up by this message. Now instead, the message is directed to stderr.