Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@othillo
Copy link
Member

@othillo othillo commented Apr 22, 2022

No description provided.

@AlessandroMinoccheri
Copy link
Contributor

Hi @othillo by removing the supported version do you mean also to update the composer.json file with an higher supported version of PHP?

@othillo othillo marked this pull request as ready for review April 22, 2022 11:16
@othillo othillo requested a review from wjzijderveld April 22, 2022 11:17
@wjzijderveld
Copy link
Member

It's a bit of a tricky thing @AlessandroMinoccheri There's no reason to assume it won't work on 7.2, we just don't test against it as that PHP version itsn't supported anymore.
To avoid confusion it's probably best to update composer.json as well, even if it means some people can't update anymore even though it would work fine.

@othillo othillo merged commit d033e7b into broadway:master Apr 23, 2022
@othillo othillo deleted the update-supported-php-versions branch April 23, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants