Manually exit process #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2a976d to
c03cbb7
Compare
Partial revert of broccolijs#476 to work around ember-cli/broccoli-babel-transpiler#169
c03cbb7 to
adadccf
Compare
|
The one failing job seemed to hit an unrelated tooling error: |
|
Re-ran CI (yarn install failed on macOS) |
|
This is a workaround, could an inline comment be added describing the rationale? The proper solution is a little more involved, and requires adding a destructor concept to broccoli pipelines, and plugins. |
|
opened an issue: #479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial revert of #476
to work around ember-cli/broccoli-babel-transpiler#169
Kept the tests and ensuring the correct exit code is called, but put back the manual process exiting.