feat: Add prop validation to the JSX components #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Visit the preview URL for this PR (updated for commit 0682092): https://ccv-honeycomb--pr442-feat-prop-validation-fmse87xo.web.app (expires Wed, 10 Apr 2024 17:59:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
broarr
approved these changes
Mar 27, 2024
| "fs-extra": "^11.1.1", | ||
| "jspsych": "^7.2.3", | ||
| "lodash": "^4.17.19", | ||
| "prop-types": "^15.8.1", |
Member
Author
There was a problem hiding this comment.
Right, I guess the react team moved prop types into its own library at some point. If/when Honeycomb becomes a separate library I think we'll move to typescript but I don't want to add the burden on new developers here
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prop-validationlinter ruleLoginandJsPsychExperimentfunctionsAppcomponents to pass props in the same order as the underlying component